Fix Elasticsearch‐gem version constraints to avoid HTTP header errors #1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
requested changes
May 1, 2025
There was a problem hiding this comment.
We don't want to lock versions for dependent gems. This could be achieved by Gemfile.
https://docs.fluentd.org/deployment/plugin-management#gemfile-option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION HERE
(check all that apply)
versionin gemspec are untouchedelasticsearch_dynamic(not required but recommended)After upgrading the elasticsearch Ruby gem to v9.0.1, Fluentd’s fluent-plugin-elasticsearch started raising:
Invalid media-type value on headers [Content-Type, Accept]
See: uken/fluent-plugin-elasticsearch#1061
elastic/elasticsearch-ruby#2660
To restore compatibility:
For users on Elasticsearch-gem 8.x, continue shipping plugin v5.x
For users on Elasticsearch-gem 9.x, bump plugin to v6.x
This change pins the appropriate plugin version to each major gem series, preventing the header‐validation error.